Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
index 1b1e7c564d27a2852dbf1163ad1c952257de7596..988cd5bc118d737cad96fec5634a16b0cd02ee18 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
+#include <utility>
+
#include "base/command_line.h"
#include "base/macros.h"
#include "base/metrics/histogram_samples.h"
@@ -314,8 +316,8 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, ChooseCredential) {
net::URLRequestStatus::FAILED);
EXPECT_CALL(url_callback, OnRequestDone(icon_url));
- SetupChooseCredentials(local_credentials.Pass(), federated_credentials.Pass(),
- origin);
+ SetupChooseCredentials(std::move(local_credentials),
+ std::move(federated_credentials), origin);
EXPECT_TRUE(IsBubbleShowing());
EXPECT_CALL(*this, OnChooseCredential(
Field(&password_manager::CredentialInfo::type,
@@ -338,8 +340,8 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, ChooseCredentialNoFocus) {
content::RunAllPendingInMessageLoop();
EXPECT_FALSE(browser()->window()->IsActive());
- SetupChooseCredentials(local_credentials.Pass(), federated_credentials.Pass(),
- origin);
+ SetupChooseCredentials(std::move(local_credentials),
+ std::move(federated_credentials), origin);
EXPECT_TRUE(IsBubbleShowing());
}
@@ -365,7 +367,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSignin) {
net::URLRequestStatus::FAILED);
EXPECT_CALL(url_callback, OnRequestDone(icon_url));
- SetupAutoSignin(local_credentials.Pass());
+ SetupAutoSignin(std::move(local_credentials));
EXPECT_TRUE(IsBubbleShowing());
ManagePasswordsBubbleView::CloseBubble();
@@ -394,7 +396,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSigninNoFocus) {
// Get rid of the warm welcome which makes the bubble sticky.
password_bubble_experiment::RecordAutoSignInPromptFirstRunExperienceWasShown(
browser()->profile()->GetPrefs());
- SetupAutoSignin(local_credentials.Pass());
+ SetupAutoSignin(std::move(local_credentials));
content::RunAllPendingInMessageLoop();
EXPECT_TRUE(IsBubbleShowing());
« no previous file with comments | « chrome/browser/ui/views/passwords/manage_password_items_view.cc ('k') | chrome/browser/ui/views/profiles/new_avatar_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698