chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc - Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/exclusive_access_bubble_views.cc ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

diff --git a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

index 27bb3a702f115c14dcebb76403a90d999ad7b5ed..a3d97c00598462531c3986a616ecd9479cfd9576 100644

--- a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

+++ b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h"

+#include <utility>

#include "base/logging.h"

#include "chrome/browser/extensions/extension_action.h"

#include "chrome/browser/extensions/extension_view_host.h"

@@ -82,9 +84,7 @@ void ExtensionActionPlatformDelegateViews::ShowPopup(

ExtensionPopup::ShowAction popup_show_action =

show_action == ExtensionActionViewController::SHOW_POPUP ?

ExtensionPopup::SHOW : ExtensionPopup::SHOW_AND_INSPECT;

- ExtensionPopup::ShowPopup(host.Pass(),

- reference_view,

- arrow,

+ ExtensionPopup::ShowPopup(std::move(host), reference_view, arrow,

popup_show_action);

}