chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc - Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc ('k') | chrome/browser/ui/views/autofill/decorated_textfield.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc

diff --git a/chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc b/chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc

index c50474031231153a0129c866486e099f3ba14095..802b40c713ab6c558aeae1bc6c13965641c26cbf 100644

--- a/chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc

+++ b/chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/views/apps/shaped_app_window_targeter.h"

+#include <utility>

#include "apps/ui/views/app_window_frame_view.h"

#include "base/macros.h"

#include "build/build_config.h"

@@ -76,7 +78,7 @@ TEST_F(ShapedAppWindowTargeterTest, HitTestBasic) {

scoped_ptr<SkRegion> region(new SkRegion);

region->op(SkIRect::MakeXYWH(0, 0, 0, 0), SkRegion::kUnion_Op);

- app_window()->UpdateShape(region.Pass());

+ app_window()->UpdateShape(std::move(region));

{

// With an empty custom shape, all events within the window should fall

// through to the root window.

@@ -101,7 +103,7 @@ TEST_F(ShapedAppWindowTargeterTest, HitTestBasic) {

region.reset(new SkRegion);

region->op(SkIRect::MakeXYWH(40, 0, 20, 100), SkRegion::kUnion_Op);

region->op(SkIRect::MakeXYWH(0, 40, 100, 20), SkRegion::kUnion_Op);

- app_window()->UpdateShape(region.Pass());

+ app_window()->UpdateShape(std::move(region));

{

// With the custom shape, the events that don't fall within the custom shape

// will go through to the root window.

@@ -159,7 +161,7 @@ TEST_F(ShapedAppWindowTargeterTest, HitTestOnlyForShapedWindow) {

scoped_ptr<SkRegion> region(new SkRegion);

region->op(SkIRect::MakeXYWH(40, 0, 20, 100), SkRegion::kUnion_Op);

region->op(SkIRect::MakeXYWH(0, 40, 100, 20), SkRegion::kUnion_Op);

- app_window()->UpdateShape(region.Pass());

+ app_window()->UpdateShape(std::move(region));

{

// With the custom shape, the events that don't fall within the custom shape

// will go through to the root window.