Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_test.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_test.cc b/chrome/browser/ui/passwords/manage_passwords_test.cc
index 9d32abda6a55372ddf136521eecd9f6bdb93149b..b3dfb7b0e4afeab52ebe9f5c57304ab840477f24 100644
--- a/chrome/browser/ui/passwords/manage_passwords_test.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_test.cc
@@ -63,8 +63,8 @@ void ManagePasswordsTest::SetupPendingPassword() {
nullptr, &client, driver.AsWeakPtr(), *test_form(), false));
test_form_manager->SimulateFetchMatchingLoginsFromPasswordStore();
ScopedVector<autofill::PasswordForm> best_matches;
- test_form_manager->OnGetPasswordStoreResults(best_matches.Pass());
- GetController()->OnPasswordSubmitted(test_form_manager.Pass());
+ test_form_manager->OnGetPasswordStoreResults(std::move(best_matches));
+ GetController()->OnPasswordSubmitted(std::move(test_form_manager));
}
void ManagePasswordsTest::SetupAutomaticPassword() {
@@ -75,7 +75,7 @@ void ManagePasswordsTest::SetupAutomaticPassword() {
scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
new password_manager::PasswordFormManager(
nullptr, &client, driver.AsWeakPtr(), *test_form(), false));
- GetController()->OnAutomaticPasswordSave(test_form_manager.Pass());
+ GetController()->OnAutomaticPasswordSave(std::move(test_form_manager));
}
void ManagePasswordsTest::SetupChooseCredentials(
@@ -88,20 +88,20 @@ void ManagePasswordsTest::SetupChooseCredentials(
kTestUsername,
make_scoped_ptr(new autofill::PasswordForm(*test_form()))));
GetController()->OnChooseCredentials(
- local_credentials.Pass(), federated_credentials.Pass(), origin,
+ std::move(local_credentials), std::move(federated_credentials), origin,
base::Bind(&ManagePasswordsTest::OnChooseCredential, this));
}
void ManagePasswordsTest::SetupAutoSignin(
ScopedVector<autofill::PasswordForm> local_credentials) {
- GetController()->OnAutoSignin(local_credentials.Pass());
+ GetController()->OnAutoSignin(std::move(local_credentials));
}
scoped_ptr<base::HistogramSamples> ManagePasswordsTest::GetSamples(
const char* histogram) {
// Ensure that everything has been properly recorded before pulling samples.
content::RunAllPendingInMessageLoop();
- return histogram_tester_.GetHistogramSamplesSinceCreation(histogram).Pass();
+ return histogram_tester_.GetHistogramSamplesSinceCreation(histogram);
}
PasswordsClientUIDelegate* ManagePasswordsTest::GetController() {

Powered by Google App Engine
This is Rietveld 408576698