Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/ui/extensions/extension_installed_bubble.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_installed_bubble.cc
diff --git a/chrome/browser/ui/extensions/extension_installed_bubble.cc b/chrome/browser/ui/extensions/extension_installed_bubble.cc
index 7f23cfefb3892a2dcaabaf69f07510e6eacd271f..74d65aa7642a6abe7fa71f2fd62953c7d24a84cf 100644
--- a/chrome/browser/ui/extensions/extension_installed_bubble.cc
+++ b/chrome/browser/ui/extensions/extension_installed_bubble.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/extensions/extension_installed_bubble.h"
#include <string>
+#include <utility>
#include "base/bind.h"
#include "base/macros.h"
@@ -47,7 +48,7 @@ class ExtensionInstalledBubbleObserver
public:
explicit ExtensionInstalledBubbleObserver(
scoped_ptr<ExtensionInstalledBubble> bubble)
- : bubble_(bubble.Pass()),
+ : bubble_(std::move(bubble)),
extension_registry_observer_(this),
animation_wait_retries_(0),
weak_factory_(this) {
@@ -115,7 +116,7 @@ class ExtensionInstalledBubbleObserver
if (bubble_->ShouldShow()) {
// Must be 2 lines because the manager will take ownership of bubble.
BubbleManager* manager = bubble_->browser()->GetBubbleManager();
- manager->ShowBubble(bubble_.Pass());
+ manager->ShowBubble(std::move(bubble_));
delete this;
return;
}
@@ -168,7 +169,7 @@ scoped_ptr<extensions::Command> GetCommand(
}
if (has_command)
result.reset(new extensions::Command(command));
- return result.Pass();
+ return result;
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698