chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc - Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc ('k') | chrome/browser/ui/apps/chrome_app_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

diff --git a/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc b/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

index 5538b297222d7f6d70b4143182a4ac562826aaa6..579728d44a7cfa93ec87e13df69a68d58017d0e7 100644

--- a/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

+++ b/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

@@ -79,17 +79,15 @@ TEST_F(AppListModelPicklerUnitTest, EmptyModel) {

TEST_F(AppListModelPicklerUnitTest, OneItem) {

AppListModel model;

- model.AddItem(make_scoped_ptr(new AppListItem("abc")).Pass());

+ model.AddItem(make_scoped_ptr(new AppListItem("abc")));

DoConsistencyChecks(&model);

}

TEST_F(AppListModelPicklerUnitTest, TwoItems) {

AppListModel model;

- AppListItem* app1 =

- model.AddItem(make_scoped_ptr(new AppListItem("abc")).Pass());

+ AppListItem* app1 = model.AddItem(make_scoped_ptr(new AppListItem("abc")));

model.SetItemNameAndShortName(app1, "hello, there", "ht");

- AppListItem* app2 =

- model.AddItem(make_scoped_ptr(new AppListItem("abc2")).Pass());

+ AppListItem* app2 = model.AddItem(make_scoped_ptr(new AppListItem("abc2")));

model.SetItemNameAndShortName(app2, "hello, there 2", "ht2");

DoConsistencyChecks(&model);

@@ -97,12 +95,10 @@ TEST_F(AppListModelPicklerUnitTest, TwoItems) {

TEST_F(AppListModelPicklerUnitTest, Images) {

AppListModel model;

- AppListItem* app1 =

- model.AddItem(make_scoped_ptr(new AppListItem("abc")).Pass());

+ AppListItem* app1 = model.AddItem(make_scoped_ptr(new AppListItem("abc")));

model.SetItemName(app1, "hello, there");

app1->SetIcon(MakeImage());

- AppListItem* app2 =

- model.AddItem(make_scoped_ptr(new AppListItem("abc2")).Pass());

+ AppListItem* app2 = model.AddItem(make_scoped_ptr(new AppListItem("abc2")));

model.SetItemName(app2, "hello, there 2");

DoConsistencyChecks(&model);

@@ -110,8 +106,7 @@ TEST_F(AppListModelPicklerUnitTest, Images) {

TEST_F(AppListModelPicklerUnitTest, EmptyImage) {

AppListModel model;

- AppListItem* app1 =

- model.AddItem(make_scoped_ptr(new AppListItem("abc")).Pass());

+ AppListItem* app1 = model.AddItem(make_scoped_ptr(new AppListItem("abc")));

model.SetItemName(app1, "hello, there");

app1->SetIcon(gfx::ImageSkia());