Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1550013002: DebugVisualizers: Add blink::Length (Closed)

Created:
4 years, 12 months ago by kojii
Modified:
4 years, 11 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DebugVisualizers: Add blink::Length This patch adds blink::Length to Visual Studio debug visualizers. This patch also moves LogFontTypeface to skia.natvis. This Skia type was accidentally put in webkit.natvis. Committed: https://crrev.com/23f39cba0e143eb69555e6bb41a108078dc5a55d Cr-Commit-Position: refs/heads/master@{#367452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/win/DebugVisualizers/skia.natvis View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/win/DebugVisualizers/webkit.natvis View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kojii
PTAL.
4 years, 11 months ago (2015-12-29 18:56:18 UTC) #2
brucedawson
lgtm
4 years, 11 months ago (2016-01-04 21:26:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550013002/1
4 years, 11 months ago (2016-01-05 00:58:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 01:41:05 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 01:41:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23f39cba0e143eb69555e6bb41a108078dc5a55d
Cr-Commit-Position: refs/heads/master@{#367452}

Powered by Google App Engine
This is Rietveld 408576698