chrome/browser/ui/autofill/autofill_dialog_models.h - Issue 15500008: Persist the choice of AutofillDataModel when using the requestAutocomplete dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_models.h

Issue 15500008: Persist the choice of AutofillDataModel when using the requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: better comment Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc ('K') | « chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_models.cc » ('j') | chrome/browser/ui/autofill/autofill_dialog_models.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_models.h

diff --git a/chrome/browser/ui/autofill/autofill_dialog_models.h b/chrome/browser/ui/autofill/autofill_dialog_models.h

index 705a0d30f750a90eb61c0e2b20349ce89faf8de9..1b7942cbfd1b97494338a9c79aa606a928ce59c3 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_models.h

+++ b/chrome/browser/ui/autofill/autofill_dialog_models.h

@@ -72,7 +72,12 @@ class SuggestionsMenuModel : public ui::SimpleMenuModel,

void SetCheckedItem(const std::string& item_key);

void SetCheckedIndex(size_t index);

- int checked_item() { return checked_item_; }

+ // Sets the item to be checked to the |n|th item that has key |item_key|.

+ // If there are fewer than |n| items that share |item_key|, the last one

+ // becomes checked.

Ilya Sherman 2013/05/21 03:54:35 nit: Please mention that this is 1-indexed rather

Evan Stade 2013/05/21 17:34:41 done. I made it 1-indexed because Nth implies 1-in

+ void SetCheckedItemNthWithKey(const std::string& item_key, size_t n);

Ilya Sherman 2013/05/21 03:54:35 What happens if there are no items that share |ite

Evan Stade 2013/05/21 17:34:41 Done.

+ int checked_item() const { return checked_item_; }

// ui::SimpleMenuModel::Delegate implementation.

virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;