editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java - Issue 15500002: Checkpoint for more inheritance error codes 'Missing inherited member' warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

Issue 15500002: Checkpoint for more inheritance error codes 'Missing inherited member' warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase with bleeding_edge Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/PropertyAccessorElementImpl.java » ('j') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

index e8465df7c238c9ee2a8f0400212075b645f83d5d..85e596f8f07fe09b2b8ff9d9e19aae7b57bae33b 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

@@ -21,6 +21,7 @@ import com.google.dart.engine.ast.ClassTypeAlias;

import com.google.dart.engine.ast.ConstructorDeclaration;

import com.google.dart.engine.ast.DeclaredIdentifier;

import com.google.dart.engine.ast.DefaultFormalParameter;

+import com.google.dart.engine.ast.EmptyFunctionBody;

import com.google.dart.engine.ast.FieldDeclaration;

import com.google.dart.engine.ast.FieldFormalParameter;

import com.google.dart.engine.ast.ForEachStatement;

@@ -524,6 +525,8 @@ public class ElementBuilder extends RecursiveASTVisitor<Void> {

getter.setLocalVariables(holder.getLocalVariables());

getter.setVariable(field);

+ getter.setAbstract(node.getBody() instanceof EmptyFunctionBody

+ && node.getExternalKeyword() == null);

getter.setGetter(true);

field.setGetter(getter);

@@ -537,6 +540,8 @@ public class ElementBuilder extends RecursiveASTVisitor<Void> {

setter.setParameters(holder.getParameters());

setter.setVariable(field);

+ setter.setAbstract(node.getBody() instanceof EmptyFunctionBody

+ && !matches(node.getExternalKeyword(), Keyword.EXTERNAL));

setter.setSetter(true);

field.setSetter(setter);

field.setFinal(false);