components/web_contents_delegate_android/web_contents_delegate_android.cc - Issue 1549993003: Switch to standard integer types in components/, part 4 of 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 1549993003: Switch to standard integer types in components/, part 4 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.h ('k') | components/web_modal/single_web_contents_dialog_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.cc

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc

index b535eb3dbd43c3817db29b414ae7d0c3c0b15a73..6a6558e5abba04464a3ff57f802e8ed3567d55f6 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc

@@ -95,8 +95,7 @@ WebContents* WebContentsDelegateAndroid::OpenURLFromTab(

params.browser_initiated_post_data.get() &&

params.browser_initiated_post_data.get()->size()) {

post_data = base::android::ToJavaByteArray(

- env,

- params.browser_initiated_post_data.get()->front_as<uint8>(),

+ env, params.browser_initiated_post_data.get()->front_as<uint8_t>(),

params.browser_initiated_post_data.get()->size());

}

Java_WebContentsDelegateAndroid_openNewTab(env,

@@ -282,9 +281,9 @@ void WebContentsDelegateAndroid::MoveContents(WebContents* source,

bool WebContentsDelegateAndroid::AddMessageToConsole(

WebContents* source,

- int32 level,

+ int32_t level,

const base::string16& message,

- int32 line_no,

+ int32_t line_no,

const base::string16& source_id) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);