Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: components/sync_sessions/revisit/page_revisit_broadcaster_unittest.cc

Issue 1549993003: Switch to standard integer types in components/, part 4 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync_sessions/revisit/page_revisit_broadcaster.h" 5 #include "components/sync_sessions/revisit/page_revisit_broadcaster.h"
6 6
7 #include <stdint.h>
8
7 #include "components/sync_sessions/revisit/page_visit_observer.h" 9 #include "components/sync_sessions/revisit/page_visit_observer.h"
8 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
9 #include "ui/base/page_transition_types.h" 11 #include "ui/base/page_transition_types.h"
10 12
11 using sync_sessions::PageVisitObserver; 13 using sync_sessions::PageVisitObserver;
12 14
13 namespace browser_sync { 15 namespace browser_sync {
14 16
15 class SyncPageRevisitBroadcasterTest : public ::testing::Test { 17 class SyncPageRevisitBroadcasterTest : public ::testing::Test {
16 protected: 18 protected:
17 PageVisitObserver::TransitionType Convert( 19 PageVisitObserver::TransitionType Convert(
18 const ui::PageTransition conversionInput) { 20 const ui::PageTransition conversionInput) {
19 return PageRevisitBroadcaster::ConvertTransitionEnum(conversionInput); 21 return PageRevisitBroadcaster::ConvertTransitionEnum(conversionInput);
20 } 22 }
21 23
22 void Check(const PageVisitObserver::TransitionType expected, 24 void Check(const PageVisitObserver::TransitionType expected,
23 const ui::PageTransition conversionInput) { 25 const ui::PageTransition conversionInput) {
24 EXPECT_EQ(expected, Convert(conversionInput)); 26 EXPECT_EQ(expected, Convert(conversionInput));
25 } 27 }
26 28
27 void Check(const PageVisitObserver::TransitionType expected, 29 void Check(const PageVisitObserver::TransitionType expected,
28 const int32 conversionInput) { 30 const int32_t conversionInput) {
29 Check(expected, ui::PageTransitionFromInt(conversionInput)); 31 Check(expected, ui::PageTransitionFromInt(conversionInput));
30 } 32 }
31 }; 33 };
32 34
33 TEST_F(SyncPageRevisitBroadcasterTest, ConvertPageInteraction) { 35 TEST_F(SyncPageRevisitBroadcasterTest, ConvertPageInteraction) {
34 Check(PageVisitObserver::kTransitionPage, ui::PAGE_TRANSITION_LINK); 36 Check(PageVisitObserver::kTransitionPage, ui::PAGE_TRANSITION_LINK);
35 Check(PageVisitObserver::kTransitionPage, 37 Check(PageVisitObserver::kTransitionPage,
36 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_BLOCKED); 38 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_BLOCKED);
37 Check(PageVisitObserver::kTransitionPage, 39 Check(PageVisitObserver::kTransitionPage,
38 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_FORWARD_BACK); 40 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_FORWARD_BACK);
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 TEST_F(SyncPageRevisitBroadcasterTest, ConvertUnknown) { 103 TEST_F(SyncPageRevisitBroadcasterTest, ConvertUnknown) {
102 Check(PageVisitObserver::kTransitionUnknown, 104 Check(PageVisitObserver::kTransitionUnknown,
103 ui::PAGE_TRANSITION_AUTO_SUBFRAME); 105 ui::PAGE_TRANSITION_AUTO_SUBFRAME);
104 Check(PageVisitObserver::kTransitionUnknown, 106 Check(PageVisitObserver::kTransitionUnknown,
105 ui::PAGE_TRANSITION_MANUAL_SUBFRAME); 107 ui::PAGE_TRANSITION_MANUAL_SUBFRAME);
106 Check(PageVisitObserver::kTransitionUnknown, 108 Check(PageVisitObserver::kTransitionUnknown,
107 ui::PAGE_TRANSITION_AUTO_TOPLEVEL); 109 ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
108 } 110 }
109 111
110 } // namespace browser_sync 112 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698