Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1549903002: Replace -webkit-transform with transform in Chrome UI (Closed)

Created:
4 years, 12 months ago by Deokjin Kim
Modified:
4 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, achuith+watch_chromium.org, dzhioev+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, rginda+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mtomasz+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace -webkit-transform with transfrom in Chrome UI BUG=455397 Committed: https://crrev.com/95c81ffa5138408c2bad11a3e6732c3ff7a2657c Cr-Commit-Position: refs/heads/master@{#384565}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Replace [wW]ebkitTransform with transform #

Patch Set 4 : Rebase CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M ui/accessibility/extensions/alt/hide-images.css View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/accessibility/extensions/colorenhancer/res/setup.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/common/js/util.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/common.css View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/tree.css View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/css/media_controls.css View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M ui/login/account_picker/user_pod_row.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/screen_container.css View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/css/bubble.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/dialogs.css View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/webui/resources/css/overlay.css View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/webui/resources/css/trash.css View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/webui/resources/css/tree.css View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/images/throbber_medium.svg View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/webui/resources/images/throbber_small.svg View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/webui/resources/js/cr/ui/card_slider.js View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 35 (13 generated)
Deokjin Kim
sadrul and dstcokwell, PTAL.
4 years, 12 months ago (2015-12-24 13:22:02 UTC) #3
sadrul
+estade@ as ui/webui owner. I can stamp the rest if webui has your approval.
4 years, 11 months ago (2016-01-04 19:52:00 UTC) #5
Dan Beam
https://codereview.chromium.org/1549903002/diff/1/ui/webui/resources/js/cr/ui/card_slider.js File ui/webui/resources/js/cr/ui/card_slider.js (right): https://codereview.chromium.org/1549903002/diff/1/ui/webui/resources/js/cr/ui/card_slider.js#newcode590 ui/webui/resources/js/cr/ui/card_slider.js:590: this.container_.style.WebkitTransform = 'translate3d(' + x + 'px, 0, 0)'; ...
4 years, 11 months ago (2016-01-04 20:27:27 UTC) #6
Deokjin Kim
On 2016/01/04 20:27:27, Dan Beam wrote: > https://codereview.chromium.org/1549903002/diff/1/ui/webui/resources/js/cr/ui/card_slider.js > File ui/webui/resources/js/cr/ui/card_slider.js (right): > > https://codereview.chromium.org/1549903002/diff/1/ui/webui/resources/js/cr/ui/card_slider.js#newcode590 ...
4 years, 11 months ago (2016-01-05 12:13:56 UTC) #7
dstockwell
On 2016/01/05 at 12:13:56, deokjin81.kim wrote: > On 2016/01/04 20:27:27, Dan Beam wrote: > > ...
4 years, 10 months ago (2016-02-02 11:59:22 UTC) #8
Deokjin Kim
On 2016/02/02 11:59:22, dstockwell wrote: > I'm not an owner of any of this code, ...
4 years, 10 months ago (2016-02-02 14:33:32 UTC) #9
dstockwell
On 2016/02/02 at 14:33:32, deokjin81.kim wrote: > On 2016/02/02 11:59:22, dstockwell wrote: > > I'm ...
4 years, 10 months ago (2016-02-22 11:15:09 UTC) #10
Evan Stade
I think I asked Dan to take a look? he's a better webui reviewer than ...
4 years, 10 months ago (2016-02-22 23:50:32 UTC) #11
Dan Beam
lgtm but: a) I only own ui/webui b) why not do this in the rest ...
4 years, 10 months ago (2016-02-23 00:27:31 UTC) #13
dstockwell
Any plans to land this patch?
4 years, 9 months ago (2016-03-23 05:59:38 UTC) #14
Deokjin Kim
webui was reviewed by Dan Beam, but the rest is not reviewed yet. So I'm ...
4 years, 9 months ago (2016-03-23 06:07:23 UTC) #15
mtomasz
ui/file_manager/* lgtm
4 years, 9 months ago (2016-03-23 06:16:01 UTC) #17
sadrul
stamp lgtm
4 years, 8 months ago (2016-03-30 14:29:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549903002/40001
4 years, 8 months ago (2016-03-30 22:54:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/11344) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-03-30 22:57:00 UTC) #22
Deokjin Kim
I rebased this CL. May I land this patch?
4 years, 8 months ago (2016-03-31 12:28:09 UTC) #23
Dan Beam
still lgtm
4 years, 8 months ago (2016-03-31 14:42:29 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549903002/60001
4 years, 8 months ago (2016-04-01 00:54:46 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/203600)
4 years, 8 months ago (2016-04-01 06:56:22 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549903002/60001
4 years, 8 months ago (2016-04-01 12:16:26 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-01 12:44:03 UTC) #33
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 12:45:40 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/95c81ffa5138408c2bad11a3e6732c3ff7a2657c
Cr-Commit-Position: refs/heads/master@{#384565}

Powered by Google App Engine
This is Rietveld 408576698