Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1549853002: Switch to standard integer types in base/files/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, tfarina, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in base/files/. BUG=138542 TBR=mark@chromium.org Committed: https://crrev.com/543540ec4430210fafe3fd49e9d4076acb4d7f6b Cr-Commit-Position: refs/heads/master@{#366804}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -140 lines) Patch
M base/files/dir_reader_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/files/dir_reader_posix_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file.h View 10 chunks +17 lines, -19 lines 0 comments Download
M base/files/file.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M base/files/file_enumerator.h View 2 chunks +5 lines, -2 lines 0 comments Download
M base/files/file_enumerator_posix.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/files/file_enumerator_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/files/file_locking_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/files/file_path_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/files/file_path_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M base/files/file_path_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path_watcher_fsevents.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/files/file_path_watcher_fsevents.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path_watcher_kqueue.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path_watcher_kqueue.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M base/files/file_path_watcher_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path_watcher_unittest.cc View 3 chunks +2 lines, -1 line 0 comments Download
M base/files/file_path_watcher_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_posix.cc View 11 chunks +25 lines, -23 lines 0 comments Download
M base/files/file_proxy.h View 5 chunks +8 lines, -5 lines 0 comments Download
M base/files/file_proxy.cc View 11 chunks +12 lines, -13 lines 0 comments Download
M base/files/file_proxy_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M base/files/file_tracing.h View 3 chunks +7 lines, -4 lines 0 comments Download
M base/files/file_tracing.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M base/files/file_unittest.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M base/files/file_util.h View 4 chunks +12 lines, -12 lines 0 comments Download
M base/files/file_util.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M base/files/file_util_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M base/files/file_util_posix.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M base/files/file_util_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_util_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_util_unittest.cc View 9 chunks +22 lines, -22 lines 0 comments Download
M base/files/file_util_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M base/files/file_win.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M base/files/important_file_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M base/files/important_file_writer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/memory_mapped_file.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/files/memory_mapped_file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/memory_mapped_file_posix.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/files/memory_mapped_file_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/files/memory_mapped_file_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/files/scoped_file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/scoped_temp_dir.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/scoped_temp_dir_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/file_tracing_provider_impl.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/tracing/file_tracing_provider_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549853002/1
5 years ago (2015-12-24 03:07:31 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/96358)
5 years ago (2015-12-24 03:29:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549853002/20001
5 years ago (2015-12-24 03:43:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-24 05:15:42 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-24 05:16:49 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/543540ec4430210fafe3fd49e9d4076acb4d7f6b
Cr-Commit-Position: refs/heads/master@{#366804}

Powered by Google App Engine
This is Rietveld 408576698