[proxies] Improve JSProxyVerify and test most proxy invariants.

[proxies] Improve JSProxyVerify and test most proxy invariants.

BUG=

Committed: https://crrev.com/f17c1d11408452548564f50c392cb8fa23a2bbdd
Cr-Commit-Position: refs/heads/master@{#33032}

[Camillo Bruni, 2015-12-23 16:53:29]

cbruni@chromium.org changed reviewers:
+ ishell@chromium.org

[Camillo Bruni, 2015-12-23 16:53:29]

PTAL

[Igor Sheludko, 2015-12-23 17:04:52]

lgtm with nits:

https://codereview.chromium.org/1549793003/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):

https://codereview.chromium.org/1549793003/diff/1/src/objects-debug.cc#newcod...
src/objects-debug.cc:823: if (target()->IsCallable()) {
You could probably rewrite these ifs like this:
  CHECK_EQ(target()->IsCallable(), map()->is_callable());
  CHECK_EQ(target()->IsConstructor(), map()->is_constructor());

https://codereview.chromium.org/1549793003/diff/1/src/objects-debug.cc#newcod...
src/objects-debug.cc:835: // There should be not properties on a Proxy.
s/not/no/

[Camillo Bruni, 2015-12-23 17:14:14]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-23 17:14:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549793003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549793003/1

[Camillo Bruni, 2015-12-23 17:16:26]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-12-23 17:16:26]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1549793003/#ps20001
(title: "addressing nits")

[commit-bot: I haz the power, 2015-12-23 17:17:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549793003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549793003/20001

[commit-bot: I haz the power, 2015-12-23 17:37:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-23 17:38:21]

Description was changed from

==========
[proxies] Improve JSProxyVerify and test most proxy invariants.

BUG=
==========

to

==========
[proxies] Improve JSProxyVerify and test most proxy invariants.

BUG=

Committed: https://crrev.com/f17c1d11408452548564f50c392cb8fa23a2bbdd
Cr-Commit-Position: refs/heads/master@{#33032}
==========

[commit-bot: I haz the power, 2015-12-23 17:38:22]

Patchset 2 (id:??) landed as
https://crrev.com/f17c1d11408452548564f50c392cb8fa23a2bbdd
Cr-Commit-Position: refs/heads/master@{#33032}

[Camillo Bruni, 2015-12-23 19:07:01]

https://codereview.chromium.org/1549793003/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):

https://codereview.chromium.org/1549793003/diff/1/src/objects-debug.cc#newcod...
src/objects-debug.cc:823: if (target()->IsCallable()) {
On 2015/12/23 at 17:04:52, Igor Sheludko wrote:
> You could probably rewrite these ifs like this:
>   CHECK_EQ(target()->IsCallable(), map()->is_callable());
>   CHECK_EQ(target()->IsConstructor(), map()->is_constructor());

Sometimes I really wonder how I got so far with programming :D