Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1549743003: PPC: Partial revert of rest parameter desugaring. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Partial revert of rest parameter desugaring. Port d3f074b23195a2426d14298dca30c4cf9183f203 Original commit message: We'll be able to optimize rest parameters in TurboFan similarly to the arguments array. This CL restores the previous behavior, and a follow-on will enable TurboFan optimization. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/fc23b4949850e68a0877e3426c438ce0f710613d Cr-Commit-Position: refs/heads/master@{#33028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-23 14:21:30 UTC) #1
mvstanton
lgtm
5 years ago (2015-12-23 14:22:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549743003/1
5 years ago (2015-12-23 14:22:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-23 14:39:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549743003/1
5 years ago (2015-12-23 14:47:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 14:49:14 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-23 14:50:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc23b4949850e68a0877e3426c438ce0f710613d
Cr-Commit-Position: refs/heads/master@{#33028}

Powered by Google App Engine
This is Rietveld 408576698