Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 1549703002: Suppress erronous TSAN errors in new EDK. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress erronous TSAN errors in new EDK. This also addresses a harmless read of uninitialized 2-bytes to quiet the Valgrind error. Also it adds a lock around the usage of initialized_ in RawChannel, even though it's not needed since it's just an optimization to avoid thread hops. BUG=561803, 571735 TBR=glider, thakis Committed: https://crrev.com/9269e9ad8cb31a90e0ecfa0b24a597776d962d5d Cr-Commit-Position: refs/heads/master@{#366727}

Patch Set 1 #

Patch Set 2 : revert change to enable new EDK by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jam
glider: build/sanitizers/tsan_suppressions.cc thakis: rest
5 years ago (2015-12-23 07:18:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549703002/10005 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549703002/10005
5 years ago (2015-12-23 07:18:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:10005)
5 years ago (2015-12-23 07:22:25 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-23 07:23:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9269e9ad8cb31a90e0ecfa0b24a597776d962d5d
Cr-Commit-Position: refs/heads/master@{#366727}

Powered by Google App Engine
This is Rietveld 408576698