Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.h

Issue 1549693002: Optimize collapsed border painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.h b/third_party/WebKit/Source/core/layout/LayoutTableSection.h
index 2239b3f5b92e7f8d54c80755a9c8923730623eab..1642a8c8a601d48063cd54e5573ed170bd1f805e 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.h
@@ -34,13 +34,6 @@ namespace blink {
// This variable is used to balance the memory consumption vs the paint invalidation time on big tables.
const float gMaxAllowedOverflowingCellRatioForFastPaintPath = 0.1f;
-enum CollapsedBorderSide {
- CBSBefore,
- CBSAfter,
- CBSStart,
- CBSEnd
-};
-
// Helper class for paintObject.
class CellSpan {
STACK_ALLOCATED();
@@ -280,12 +273,6 @@ public:
void rowLogicalHeightChanged(LayoutTableRow*);
- void removeCachedCollapsedBorders(const LayoutTableCell*);
- // Returns true if any collapsed borders of the cell changed.
- bool setCachedCollapsedBorder(const LayoutTableCell*, CollapsedBorderSide, const CollapsedBorderValue&);
- // Returns null if the border is not cached (there is no such collapsed border or the border is invisible).
- const CollapsedBorderValue* cachedCollapsedBorder(const LayoutTableCell*, CollapsedBorderSide) const;
-
// distributeExtraLogicalHeightToRows methods return the *consumed* extra logical height.
// FIXME: We may want to introduce a structure holding the in-flux layout information.
int distributeExtraLogicalHeightToRows(int extraLogicalHeight);
@@ -412,12 +399,6 @@ private:
// The use is to disable a painting optimization where we just paint the
// invalidated cells.
bool m_hasMultipleCellLevels;
-
- // This map holds the collapsed border values for cells with collapsed borders.
- // It is held at LayoutTableSection level to spare memory consumption by table cells.
- // Invisible borders are never stored in this map.
- using CellsCollapsedBordersMap = HashMap<std::pair<const LayoutTableCell*, int>, CollapsedBorderValue>;
- CellsCollapsedBordersMap m_cellsCollapsedBorders;
};
DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableSection, isTableSection());

Powered by Google App Engine
This is Rietveld 408576698