Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1549633005: Move CloseHandle hook into base/debug. (Closed)

Created:
5 years ago by Will Harris
Modified:
4 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CloseHandle hook into base/debug. This has no changes to behavior, it is merely to prepare the code for adding tests. BUG=571304 Committed: https://crrev.com/b5408308ce788760f4539a631ca5ed43e037261a Cr-Commit-Position: refs/heads/master@{#367889}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -347 lines) Patch
M base/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M base/base.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A base/debug/close_handle_hook_win.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + base/debug/close_handle_hook_win.cc View 1 2 5 chunks +18 lines, -30 lines 0 comments Download
M chrome/BUILD.gn View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 4 chunks +23 lines, -3 lines 0 comments Download
D chrome/app/close_handle_hook_win.h View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/app/close_handle_hook_win.cc View 1 2 1 chunk +0 lines, -288 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Will Harris
PTAL. This time there really is no change to any behavior at all, srsly. For ...
5 years ago (2015-12-23 02:22:28 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
4 years, 11 months ago (2016-01-06 17:33:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549633005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549633005/40001
4 years, 11 months ago (2016-01-06 19:02:32 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-06 20:24:15 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 20:25:31 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b5408308ce788760f4539a631ca5ed43e037261a
Cr-Commit-Position: refs/heads/master@{#367889}

Powered by Google App Engine
This is Rietveld 408576698