Makes NetworkChangeType enum public.

net/base/network_change_notifier.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/network_change_notifier.h"
 
 #include <limits>
 
 #include "base/macros.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 905 matching lines @@
 }
 
 // static
 void NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
     ConnectionType type) {
   if (g_network_change_notifier)
     g_network_change_notifier->NotifyObserversOfNetworkChangeImpl(type);
 }
 
 // static
+void NetworkChangeNotifier::NotifyObserversOfSpecificNetworkChangeForTests(
+    NetworkChangeType type,
+    NetworkHandle network) {
+  if (g_network_change_notifier) {
+    g_network_change_notifier->NotifyObserversOfSpecificNetworkChangeImpl(
+        type, network);
+  }
+}
+
+// static
 void NetworkChangeNotifier::NotifyObserversOfInitialDNSConfigReadForTests() {
   if (g_network_change_notifier)
     g_network_change_notifier->NotifyObserversOfInitialDNSConfigReadImpl();
 }
 
 // static
 void NetworkChangeNotifier::NotifyObserversOfMaxBandwidthChangeForTests(
     double max_bandwidth_mbps,
     ConnectionType type) {
   if (g_network_change_notifier) {
@@ skipping 127 matching lines @@
       !NetworkChangeNotifier::test_notifications_only_) {
     g_network_change_notifier->NotifyObserversOfInitialDNSConfigReadImpl();
   }
 }
 
 // static
 void NetworkChangeNotifier::NotifyObserversOfSpecificNetworkChange(
     NetworkChangeType type,
     NetworkHandle network) {
   if (g_network_change_notifier &&
       !NetworkChangeNotifier::test_notifications_only_) {

[Ryan Hamilton, 2015/12/22 23:12:57]

If you can arrange for this variable to be false (it looks like there is a
setter for it) then I think you can simply use this method?

[pauljensen, 2015/12/29 13:35:41]

+1 to Ryan's comment.  It should be false in your tests as your don't explicitly
set it to true (it defaults to false).  This method is protected, but you have
your own NCN impl in your test so it should be able to freely call this
function.

     g_network_change_notifier->NotifyObserversOfSpecificNetworkChangeImpl(
         type, network);
   }
 }
 
 // static
 void NetworkChangeNotifier::SetDnsConfig(const DnsConfig& config) {
   if (!g_network_change_notifier)
     return;
   g_network_change_notifier->network_state_->SetDnsConfig(config);
@@ skipping 79 matching lines @@
 
 NetworkChangeNotifier::DisableForTest::~DisableForTest() {
   DCHECK(!g_network_change_notifier);
   g_network_change_notifier = network_change_notifier_;
 }
 
 void NetworkChangeNotifier::DNSObserver::OnInitialDNSConfigRead() {
 }
 
 }  // namespace net