pkg/compiler/lib/src/js/placeholder_safety.dart - Issue 1549603002: Add 'Math' to list of safe global JavaScript names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js/placeholder_safety.dart

Issue 1549603002: Add 'Math' to list of safe global JavaScript names. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js/placeholder_safety.dart

diff --git a/pkg/compiler/lib/src/js/placeholder_safety.dart b/pkg/compiler/lib/src/js/placeholder_safety.dart

index 67ff5631a58d195d50550993a5647abbc77a2b78..b103489dada8fd20a806408d003c7f5cd3f2a957 100644

--- a/pkg/compiler/lib/src/js/placeholder_safety.dart

+++ b/pkg/compiler/lib/src/js/placeholder_safety.dart

@@ -303,6 +303,7 @@ class PlaceholderSafetyAnalysis extends js.BaseVisitor<int> {

case 'Array':

case 'Date':

case 'Function':

+ case 'Math':

case 'Number':

case 'Object':

case 'RegExp':

« no previous file with comments | « no previous file | no next file » | no next file with comments »