dashboard/dashboard/debug_alert_test.py - Issue 1549583002: In /graph_json, check internal_only on Test entity and skip test for all Row entities.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/debug_alert_test.py

Issue 1549583002: In /graph_json, check internal_only on Test entity and skip test for all Row entities. (Closed) Base URL: https://github.com/catapult-project/catapult@master

Patch Set: Fixed assertions Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dashboard/dashboard/debug_alert_test.py

diff --git a/dashboard/dashboard/debug_alert_test.py b/dashboard/dashboard/debug_alert_test.py

index b8954567d4ec62f6fd68b6ae91d57a32b4863d6c..30edd49252eb8f59b90841d1db68cb0ababd67ad 100644

--- a/dashboard/dashboard/debug_alert_test.py

+++ b/dashboard/dashboard/debug_alert_test.py

@@ -30,6 +30,7 @@ class DebugAlertTest(testing_common.TestCase):

app = webapp2.WSGIApplication(

[('/debug_alert', debug_alert.DebugAlertHandler)])

self.testapp = webtest.TestApp(app)

+ self.PatchDatastoreHooksRequest()

def _AddSampleData(self):

"""Adds a Test and Row entities, and returns the Test key."""

@@ -147,7 +148,7 @@ class DebugAlertTest(testing_common.TestCase):

def testFetchLatestRows(self):

test_key = self._AddSampleData()

- rows = debug_alert._FetchLatestRows(test_key, 4)

+ rows = debug_alert._FetchLatestRows(test_key.get(), 4)

revisions = [r.revision for r in rows]

self.assertEqual([316, 317, 318, 319], revisions)

« no previous file with comments | « dashboard/dashboard/debug_alert.py ('k') | dashboard/dashboard/graph_csv.py » ('j') | no next file with comments »