In /graph_json, check internal_only on Test entity and skip test for all Row entities.

dashboard/dashboard/graph_revisions.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Handler to serve a simple time series for all points in a series.
 
 This is used to show the revision slider for a chart; it includes data
 for all past points, including those that are not recent. Each entry
 in the returned list is a 3-item list: [revision, value, timestamp].
 The revisions and values are used to plot a mini-chart, and the timestamps
@@ skipping 60 matching lines @@
 
 def _UpdateCache(test_key):
   """Queries Rows for a test then updates the cache.
 
   Args:
     test_key: ndb.Key for a Test entity.
 
   Returns:
     The list of triplets that was just fetched and set in the cache.
   """
-  if not test_key.get():
-    # The caching can actually proceed even if the Test entity doesn't exist,
-    # but a non-existent Test entity definitely indicates something is wrong.
-    logging.warn('Test not found: %s', utils.TestPath(test_key))
+  test = test_key.get()
+  if not test:
+    return

[qyearsley, 2015/12/28 22:50:56]

Should we return [] here? Or explicitly return None and mention this in the
Returns part of the docstring above?

[sullivan, 2015/12/29 03:36:07]

I changed it to []

+  assert(utils.IsInternalUser() or not test.internal_only)
+  datastore_hooks.SetSinglePrivilegedRequest()
 
   # A projection query queries just for the values of particular properties;
   # this is faster than querying for whole entities.
   query = graph_data.Row.query(projection=['revision', 'value', 'timestamp'])
   query = query.filter(graph_data.Row.parent_test == test_key)
 
   # Using a large batch_size speeds up queries with > 1000 Rows.
   rows = map(_MakeTriplet, query.iter(batch_size=1000))
+  # Note: Unit tests do not call datastore_hooks with the above query, but
+  # it is called in production and with more recent SDK.
+  datastore_hooks.CancelSinglePrivilegedRequest()
   SetCache(utils.TestPath(test_key), rows)
   return rows
 
 
 def _MakeTriplet(row):
   """Makes a 3-item list of revision, value and timestamp for a Row."""
   timestamp = utils.TimestampMilliseconds(row.timestamp)
   return [row.revision, row.value, timestamp]
 
 
@@ skipping 21 matching lines @@
     revisions = [r[0] for r in graph_rows]
     index = bisect.bisect_left(revisions, row.revision)
     if index < len(revisions) - 1:
       if revisions[index + 1] == row.revision:
         return  # Already in cache.
     graph_rows.insert(index, _MakeTriplet(row))
 
   for test_key in test_key_to_rows:
     graph_rows = test_key_to_rows[test_key]
     SetCache(utils.TestPath(test_key), graph_rows)