Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1549573002: [download] DownloadTest.Resumption_Automatic should check final path. (Closed)

Created:
5 years ago by asanka
Modified:
5 years ago
Reviewers:
svaldez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@path-reservation-tracker-owned-by-di
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[download] DownloadTest.Resumption_Automatic should check final path. Automatic resumption stresses the download target determination in ways that regular resumption doesn't. Add a check for Resumption_Automatic test to verify that the correct target path is determined. R=svaldez@chromium.org BUG=7648 Committed: https://crrev.com/f13c2a3e3ed93b92dc92e5e9accc7e9fb9470bb3 Cr-Commit-Position: refs/heads/master@{#366664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
asanka
PTAL?
5 years ago (2015-12-22 19:06:49 UTC) #1
svaldez
lgtm
5 years ago (2015-12-22 19:50:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549573002/1
5 years ago (2015-12-22 21:55:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 21:59:35 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-22 22:00:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f13c2a3e3ed93b92dc92e5e9accc7e9fb9470bb3
Cr-Commit-Position: refs/heads/master@{#366664}

Powered by Google App Engine
This is Rietveld 408576698