Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1549503002: Return AffineTransform from SVGTextFragment::buildFragmentTransform (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return AffineTransform from SVGTextFragment::buildFragmentTransform Instead of passing an AffineTransform as an out-parameter, just return it instead. Since we always copy the resulting transform into the out-parameter anyway, there should be no loss of efficiency. This also enables some of the users to be written in a more compact way. Also add boundingBox(), boundingQuad() and overflowBoundingBox() helpers to SVGTextFragment and use where possible. BUG=571415 Committed: https://crrev.com/c9cbd28cd596618f61dc47b897aee61382004e28 Cr-Commit-Position: refs/heads/master@{#366713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -89 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h View 3 chunks +47 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp View 4 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 5 chunks +11 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 4 chunks +6 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fs
5 years ago (2015-12-22 11:59:17 UTC) #3
pdr.
lgtm
5 years ago (2015-12-23 03:29:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549503002/1
5 years ago (2015-12-23 03:30:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 06:23:49 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-23 06:24:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9cbd28cd596618f61dc47b897aee61382004e28
Cr-Commit-Position: refs/heads/master@{#366713}

Powered by Google App Engine
This is Rietveld 408576698