remoting/host/win/worker_process_launcher.cc - Issue 1549493004: Use std::move() instead of .Pass() in remoting/host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/win/worker_process_launcher.cc

Issue 1549493004: Use std::move() instead of .Pass() in remoting/host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_not_pass

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/audio_capturer_linux.cc ('K') | « remoting/host/win/unprivileged_process_delegate.cc ('k') | remoting/host/win/worker_process_launcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/win/worker_process_launcher.cc

diff --git a/remoting/host/win/worker_process_launcher.cc b/remoting/host/win/worker_process_launcher.cc

index 6daf02f8b4889375a3e2c76f61fdec7a3075a7cc..3b2656f73908c0c39a0f14d9180d9315a412b1b0 100644

--- a/remoting/host/win/worker_process_launcher.cc

+++ b/remoting/host/win/worker_process_launcher.cc

@@ -55,7 +55,7 @@ WorkerProcessLauncher::WorkerProcessLauncher(

scoped_ptr<WorkerProcessLauncher::Delegate> launcher_delegate,

WorkerProcessIpcDelegate* ipc_handler)

: ipc_handler_(ipc_handler),

- launcher_delegate_(launcher_delegate.Pass()),

+ launcher_delegate_(std::move(launcher_delegate)),

exit_code_(CONTROL_C_EXIT),

ipc_enabled_(false),

kill_process_timeout_(

@@ -119,7 +119,7 @@ void WorkerProcessLauncher::OnProcessLaunched(

}

ipc_enabled_ = true;

- worker_process_ = worker_process.Pass();

+ worker_process_ = std::move(worker_process);

}

void WorkerProcessLauncher::OnFatalError() {