Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: remoting/host/gcd_rest_client_unittest.cc

Issue 1549493004: Use std::move() instead of .Pass() in remoting/host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_not_pass
Patch Set: include <utility> Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/host/gcd_rest_client.cc ('k') | remoting/host/gcd_state_updater.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/gcd_rest_client.h" 5 #include "remoting/host/gcd_rest_client.h"
6 6
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "base/test/simple_test_clock.h" 8 #include "base/test/simple_test_clock.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "net/url_request/test_url_fetcher_factory.h" 10 #include "net/url_request/test_url_fetcher_factory.h"
(...skipping 10 matching lines...) Expand all
21 "<fake_access_token>") {} 21 "<fake_access_token>") {}
22 22
23 void OnRequestComplete(GcdRestClient::Result result) { 23 void OnRequestComplete(GcdRestClient::Result result) {
24 ++counter_; 24 ++counter_;
25 last_result_ = result; 25 last_result_ = result;
26 } 26 }
27 27
28 scoped_ptr<base::DictionaryValue> MakePatchDetails(int id) { 28 scoped_ptr<base::DictionaryValue> MakePatchDetails(int id) {
29 scoped_ptr<base::DictionaryValue> patch_details(new base::DictionaryValue); 29 scoped_ptr<base::DictionaryValue> patch_details(new base::DictionaryValue);
30 patch_details->SetInteger("id", id); 30 patch_details->SetInteger("id", id);
31 return patch_details.Pass(); 31 return patch_details;
32 } 32 }
33 33
34 void CreateClient(OAuthTokenGetter* token_getter = nullptr) { 34 void CreateClient(OAuthTokenGetter* token_getter = nullptr) {
35 if (!token_getter) { 35 if (!token_getter) {
36 token_getter = &default_token_getter_; 36 token_getter = &default_token_getter_;
37 } 37 }
38 client_.reset(new GcdRestClient("http://gcd_base_url", "<gcd_device_id>", 38 client_.reset(new GcdRestClient("http://gcd_base_url", "<gcd_device_id>",
39 nullptr, token_getter)); 39 nullptr, token_getter));
40 client_->SetClockForTest(make_scoped_ptr(new base::SimpleTestClock)); 40 client_->SetClockForTest(make_scoped_ptr(new base::SimpleTestClock));
41 } 41 }
42 42
43 protected: 43 protected:
44 net::TestURLFetcherFactory url_fetcher_factory_; 44 net::TestURLFetcherFactory url_fetcher_factory_;
45 FakeOAuthTokenGetter default_token_getter_; 45 FakeOAuthTokenGetter default_token_getter_;
46 scoped_ptr<GcdRestClient> client_; 46 scoped_ptr<GcdRestClient> client_;
47 int counter_ = 0; 47 int counter_ = 0;
48 GcdRestClient::Result last_result_ = GcdRestClient::OTHER_ERROR; 48 GcdRestClient::Result last_result_ = GcdRestClient::OTHER_ERROR;
49 49
50 private: 50 private:
51 base::MessageLoop message_loop_; 51 base::MessageLoop message_loop_;
52 }; 52 };
53 53
54 TEST_F(GcdRestClientTest, NetworkErrorGettingToken) { 54 TEST_F(GcdRestClientTest, NetworkErrorGettingToken) {
55 FakeOAuthTokenGetter token_getter(OAuthTokenGetter::NETWORK_ERROR, "", ""); 55 FakeOAuthTokenGetter token_getter(OAuthTokenGetter::NETWORK_ERROR, "", "");
56 CreateClient(&token_getter); 56 CreateClient(&token_getter);
57 57
58 client_->PatchState(MakePatchDetails(0).Pass(), 58 client_->PatchState(MakePatchDetails(0),
59 base::Bind(&GcdRestClientTest::OnRequestComplete, 59 base::Bind(&GcdRestClientTest::OnRequestComplete,
60 base::Unretained(this))); 60 base::Unretained(this)));
61 base::RunLoop().RunUntilIdle(); 61 base::RunLoop().RunUntilIdle();
62 62
63 EXPECT_EQ(1, counter_); 63 EXPECT_EQ(1, counter_);
64 EXPECT_EQ(GcdRestClient::NETWORK_ERROR, last_result_); 64 EXPECT_EQ(GcdRestClient::NETWORK_ERROR, last_result_);
65 } 65 }
66 66
67 TEST_F(GcdRestClientTest, AuthErrorGettingToken) { 67 TEST_F(GcdRestClientTest, AuthErrorGettingToken) {
68 FakeOAuthTokenGetter token_getter(OAuthTokenGetter::AUTH_ERROR, "", ""); 68 FakeOAuthTokenGetter token_getter(OAuthTokenGetter::AUTH_ERROR, "", "");
69 CreateClient(&token_getter); 69 CreateClient(&token_getter);
70 70
71 client_->PatchState(MakePatchDetails(0).Pass(), 71 client_->PatchState(MakePatchDetails(0),
72 base::Bind(&GcdRestClientTest::OnRequestComplete, 72 base::Bind(&GcdRestClientTest::OnRequestComplete,
73 base::Unretained(this))); 73 base::Unretained(this)));
74 base::RunLoop().RunUntilIdle(); 74 base::RunLoop().RunUntilIdle();
75 75
76 EXPECT_EQ(1, counter_); 76 EXPECT_EQ(1, counter_);
77 EXPECT_EQ(GcdRestClient::OTHER_ERROR, last_result_); 77 EXPECT_EQ(GcdRestClient::OTHER_ERROR, last_result_);
78 } 78 }
79 79
80 TEST_F(GcdRestClientTest, NetworkErrorOnPost) { 80 TEST_F(GcdRestClientTest, NetworkErrorOnPost) {
81 CreateClient(); 81 CreateClient();
82 82
83 client_->PatchState(MakePatchDetails(0).Pass(), 83 client_->PatchState(MakePatchDetails(0),
84 base::Bind(&GcdRestClientTest::OnRequestComplete, 84 base::Bind(&GcdRestClientTest::OnRequestComplete,
85 base::Unretained(this))); 85 base::Unretained(this)));
86 net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0); 86 net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
87 87
88 base::RunLoop().RunUntilIdle(); 88 base::RunLoop().RunUntilIdle();
89 89
90 ASSERT_TRUE(fetcher); 90 ASSERT_TRUE(fetcher);
91 fetcher->set_response_code(0); 91 fetcher->set_response_code(0);
92 fetcher->delegate()->OnURLFetchComplete(fetcher); 92 fetcher->delegate()->OnURLFetchComplete(fetcher);
93 EXPECT_EQ(1, counter_); 93 EXPECT_EQ(1, counter_);
94 EXPECT_EQ(GcdRestClient::NETWORK_ERROR, last_result_); 94 EXPECT_EQ(GcdRestClient::NETWORK_ERROR, last_result_);
95 } 95 }
96 96
97 TEST_F(GcdRestClientTest, OtherErrorOnPost) { 97 TEST_F(GcdRestClientTest, OtherErrorOnPost) {
98 CreateClient(); 98 CreateClient();
99 99
100 client_->PatchState(MakePatchDetails(0).Pass(), 100 client_->PatchState(MakePatchDetails(0),
101 base::Bind(&GcdRestClientTest::OnRequestComplete, 101 base::Bind(&GcdRestClientTest::OnRequestComplete,
102 base::Unretained(this))); 102 base::Unretained(this)));
103 net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0); 103 net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
104 104
105 base::RunLoop().RunUntilIdle(); 105 base::RunLoop().RunUntilIdle();
106 106
107 ASSERT_TRUE(fetcher); 107 ASSERT_TRUE(fetcher);
108 fetcher->set_response_code(500); 108 fetcher->set_response_code(500);
109 fetcher->delegate()->OnURLFetchComplete(fetcher); 109 fetcher->delegate()->OnURLFetchComplete(fetcher);
110 EXPECT_EQ(1, counter_); 110 EXPECT_EQ(1, counter_);
111 EXPECT_EQ(GcdRestClient::OTHER_ERROR, last_result_); 111 EXPECT_EQ(GcdRestClient::OTHER_ERROR, last_result_);
112 } 112 }
113 113
114 TEST_F(GcdRestClientTest, NoSuchHost) { 114 TEST_F(GcdRestClientTest, NoSuchHost) {
115 CreateClient(); 115 CreateClient();
116 116
117 client_->PatchState(MakePatchDetails(0).Pass(), 117 client_->PatchState(MakePatchDetails(0),
118 base::Bind(&GcdRestClientTest::OnRequestComplete, 118 base::Bind(&GcdRestClientTest::OnRequestComplete,
119 base::Unretained(this))); 119 base::Unretained(this)));
120 net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0); 120 net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
121 121
122 base::RunLoop().RunUntilIdle(); 122 base::RunLoop().RunUntilIdle();
123 123
124 ASSERT_TRUE(fetcher); 124 ASSERT_TRUE(fetcher);
125 fetcher->set_response_code(404); 125 fetcher->set_response_code(404);
126 fetcher->delegate()->OnURLFetchComplete(fetcher); 126 fetcher->delegate()->OnURLFetchComplete(fetcher);
127 EXPECT_EQ(1, counter_); 127 EXPECT_EQ(1, counter_);
128 EXPECT_EQ(GcdRestClient::NO_SUCH_HOST, last_result_); 128 EXPECT_EQ(GcdRestClient::NO_SUCH_HOST, last_result_);
129 } 129 }
130 130
131 TEST_F(GcdRestClientTest, Succeed) { 131 TEST_F(GcdRestClientTest, Succeed) {
132 CreateClient(); 132 CreateClient();
133 133
134 client_->PatchState(MakePatchDetails(0).Pass(), 134 client_->PatchState(MakePatchDetails(0),
135 base::Bind(&GcdRestClientTest::OnRequestComplete, 135 base::Bind(&GcdRestClientTest::OnRequestComplete,
136 base::Unretained(this))); 136 base::Unretained(this)));
137 net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0); 137 net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
138 138
139 base::RunLoop().RunUntilIdle(); 139 base::RunLoop().RunUntilIdle();
140 140
141 ASSERT_TRUE(fetcher); 141 ASSERT_TRUE(fetcher);
142 EXPECT_EQ("http://gcd_base_url/devices/%3Cgcd_device_id%3E/patchState", 142 EXPECT_EQ("http://gcd_base_url/devices/%3Cgcd_device_id%3E/patchState",
143 fetcher->GetOriginalURL().spec()); 143 fetcher->GetOriginalURL().spec());
144 EXPECT_EQ( 144 EXPECT_EQ(
145 "{\"patches\":[{\"patch\":{\"id\":0},\"timeMs\":0.0}]," 145 "{\"patches\":[{\"patch\":{\"id\":0},\"timeMs\":0.0}],"
146 "\"requestTimeMs\":0.0}", 146 "\"requestTimeMs\":0.0}",
147 fetcher->upload_data()); 147 fetcher->upload_data());
148 EXPECT_EQ("application/json", fetcher->upload_content_type()); 148 EXPECT_EQ("application/json", fetcher->upload_content_type());
149 fetcher->set_response_code(200); 149 fetcher->set_response_code(200);
150 fetcher->delegate()->OnURLFetchComplete(fetcher); 150 fetcher->delegate()->OnURLFetchComplete(fetcher);
151 EXPECT_EQ(1, counter_); 151 EXPECT_EQ(1, counter_);
152 EXPECT_EQ(GcdRestClient::SUCCESS, last_result_); 152 EXPECT_EQ(GcdRestClient::SUCCESS, last_result_);
153 } 153 }
154 154
155 } // namespace remoting 155 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/host/gcd_rest_client.cc ('k') | remoting/host/gcd_state_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698