Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: tools/gn/target.cc

Issue 1549483003: Disable generated file check for libs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment to content/app/BUILD.gn Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/app/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 0d275ac93584e1a77c58c2ae00099ee75b5f865b..dfa37ba6e23d55466da4d401de980fb348f715f4 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -552,10 +552,8 @@ void Target::CheckSourcesGenerated() const {
CheckSourceGenerated(file);
for (const SourceFile& file : inputs_)
CheckSourceGenerated(file);
- for (size_t i = 0; i < all_libs_.size(); i++) {
- if (all_libs_[i].is_source_file())
- CheckSourceGenerated(all_libs_[i].source_file());
- }
+ // TODO(agrieve): Check all_libs_ here as well (those that are source files).
+ // http://crbug.com/571731
}
void Target::CheckSourceGenerated(const SourceFile& source) const {
« no previous file with comments | « content/app/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698