Disable generated file check for libs

Disable generated file check for libs

They cause too many failures for target_os="win".

BUG=571731
Committed: https://crrev.com/f0f095bd29216918bffaaa381d6d568d51a0e87f
Cr-Commit-Position: refs/heads/master@{#367603}

[agrieve, 2015-12-23 03:25:21]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[agrieve, 2015-12-23 03:25:22]

The offending target is //base/allocator:allocator_shim. Tried for a while to
change deps -> public_deps, but there's just too many of them thanks to
//content/app/* depending on //base/allocator.

There's already a TODO there to remove the dependency, so added the bug id to
that comment.

That said... is it really the case that the dependency chain needs to be
public_deps? I can't figure out why "deps" isn't sufficient for this. If public
deps is required, maybe we should add a parameter that asserts that a target is
only ever depended on via public_deps (fails if put in deps)?

[agrieve, 2015-12-23 03:26:28]

On 2015/12/23 03:25:22, agrieve wrote:
> The offending target is //base/allocator:allocator_shim. Tried for a while to
> change deps -> public_deps, but there's just too many of them thanks to
> //content/app/* depending on //base/allocator.
> 
> There's already a TODO there to remove the dependency, so added the bug id to
> that comment.
> 
> That said... is it really the case that the dependency chain needs to be
> public_deps? I can't figure out why "deps" isn't sufficient for this. If
public
> deps is required, maybe we should add a parameter that asserts that a target
is
> only ever depended on via public_deps (fails if put in deps)?

Copied it into the bug, but you can see the failure directly via
https://codereview.chromium.org/1539403004/

[brettw, 2016-01-05 18:03:49]

lgtm

[agrieve, 2016-01-05 18:35:51]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-01-05 18:37:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549483003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549483003/20001

[commit-bot: I haz the power, 2016-01-05 19:17:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-05 19:18:22]

Description was changed from

==========
Disable generated file check for libs

They cause too many failures for target_os="win".

BUG=571731
==========

to

==========
Disable generated file check for libs

They cause too many failures for target_os="win".

BUG=571731

Committed: https://crrev.com/f0f095bd29216918bffaaa381d6d568d51a0e87f
Cr-Commit-Position: refs/heads/master@{#367603}
==========

[commit-bot: I haz the power, 2016-01-05 19:18:23]

Patchset 2 (id:??) landed as
https://crrev.com/f0f095bd29216918bffaaa381d6d568d51a0e87f
Cr-Commit-Position: refs/heads/master@{#367603}