src/codec/SkCodecImageGenerator.h - Issue 1549473003: Add getYUV8Planes() API to SkCodec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/codec/SkCodecImageGenerator.h

Issue 1549473003: Add getYUV8Planes() API to SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add a test to DM Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2015 Google Inc.	2 * Copyright 2015 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7	7

8 #include "SkCodec.h"	8 #include "SkCodec.h"

9 #include "SkData.h"	9 #include "SkData.h"

10 #include "SkImageGenerator.h"	10 #include "SkImageGenerator.h"

(...skipping 21 matching lines...) Expand all Loading...
32 private:	32 private:

33 /*	33 /*

34 * Takes ownership of codec	34 * Takes ownership of codec

35 * Refs the data	35 * Refs the data

36 */	36 */

37 SkCodecImageGenerator(SkCodec* codec, SkData* data);	37 SkCodecImageGenerator(SkCodec* codec, SkData* data);

38	38

39 SkAutoTDelete<SkCodec> fCodec;	39 SkAutoTDelete<SkCodec> fCodec;

40 SkAutoTUnref<SkData> fData;	40 SkAutoTUnref<SkData> fData;

41	41

	42 int fYWidth;
	scroggo 2016/01/19 18:37:48 I think we should initialize these to some bad val I think we should initialize these to some bad value (e.g. 0?) and assert that they are not 0 when we actually need to use them. Also, it looks like these aren't needed once we change the API of SkImageGenerator? Can you add a comment and/or macro to only include them until we make the change? msarett 2016/01/19 22:35:27 Done. Show quoted text On 2016/01/19 18:37:48, scroggo wrote: > I think we should initialize these to some bad value (e.g. 0?) and assert that > they are not 0 when we actually need to use them. > > Also, it looks like these aren't needed once we change the API of > SkImageGenerator? Can you add a comment and/or macro to only include them until > we make the change? Done.
	43 int fUWidth;

	44 int fVWidth;

	45

42 typedef SkImageGenerator INHERITED;	46 typedef SkImageGenerator INHERITED;

43 };	47 };

OLD	NEW

« dm/DMSrcSink.cpp ('K') | « resources/mandrill_h2v1.jpg ('k') | src/codec/SkCodecImageGenerator.cpp » ('j') | src/codec/SkCodecImageGenerator.cpp » ('J')