Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1549443002: [Sync] Remove PSS::IsOAuthRefreshTokenAvailable (Closed)

Created:
5 years ago by pavely
Modified:
4 years, 12 months ago
Reviewers:
Nicolas Zea, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tim+watch_chromium.org, michaelpg+watch-options_chromium.org, zea+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, tommycli
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove PSS::IsOAuthRefreshTokenAvailable I realised that PSS::IsOAuthRefreshTokenAvailable is never called. This change is to remove it and all references. BUG= Committed: https://crrev.com/4e9e5829f8d608c36a2d0967188f0427ac1df1a5 Cr-Commit-Position: refs/heads/master@{#366961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc View 10 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 10 chunks +0 lines, -20 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_mock.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
pavely
5 years ago (2015-12-22 18:52:53 UTC) #3
Nicolas Zea
nice! LGTM
5 years ago (2015-12-22 19:54:31 UTC) #4
pavely
+dbeam@ for chrome/browser/ui/webui/*
5 years ago (2015-12-22 20:21:02 UTC) #6
Dan Beam
lgtm /cc tommycli@
4 years, 12 months ago (2015-12-24 05:17:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549443002/1
4 years, 12 months ago (2015-12-28 06:59:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 07:53:12 UTC) #11
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 07:53:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e9e5829f8d608c36a2d0967188f0427ac1df1a5
Cr-Commit-Position: refs/heads/master@{#366961}

Powered by Google App Engine
This is Rietveld 408576698