Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 1549383002: MIPS64: Fix [runtime] Introduce dedicated JSBoundFunction to represent bound functions. (Closed)

Created:
4 years, 12 months ago by ivica.bogosavljevic
Modified:
4 years, 12 months ago
Reviewers:
ilija.pavlovic, Michael Achenbach, miran.karic, Michael Hablich, akos.palfi.imgtec, paul.l...
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix [runtime] Introduce dedicated JSBoundFunction to represent bound functions. Fix 97def8070cbb979419c041c3732d5e11779f79da On MIPS64, the address of BoundTargetFunction was calculated badly because instruction ADD was used for this instead of instruction DADD. This caused flaky crashes of several tests. TEST=mjsunit/es6/debug-step-into-constructor,mjsunit/es6/array-of, mjsunit/function-bind,... BUG= Committed: https://crrev.com/7b42c6cfc665a81b903ffed709883121b3acee43 Cr-Commit-Position: refs/heads/master@{#33048}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips64/builtins-mips64.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 19 (8 generated)
ivica.bogosavljevic
PTAL
4 years, 12 months ago (2015-12-28 13:45:29 UTC) #2
ivica.bogosavljevic
https://codereview.chromium.org/1549383002/diff/1/src/mips64/builtins-mips64.cc File src/mips64/builtins-mips64.cc (right): https://codereview.chromium.org/1549383002/diff/1/src/mips64/builtins-mips64.cc#newcode2179 src/mips64/builtins-mips64.cc:2179: __ Daddu(at, at, Operand(Code::kHeaderSize - kHeapObjectTag)); Full list of ...
4 years, 12 months ago (2015-12-28 13:46:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549383002/1
4 years, 12 months ago (2015-12-28 13:48:51 UTC) #5
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 12 months ago (2015-12-28 13:48:52 UTC) #7
paul.l...
LGTM. Please do retry the CQ dry-run, per separate email I just sent. Feel free ...
4 years, 12 months ago (2015-12-28 14:52:19 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549383002/1
4 years, 12 months ago (2015-12-28 15:03:23 UTC) #11
ivica.bogosavljevic
On 2015/12/28 14:52:19, paul.l... wrote: > LGTM. Please do retry the CQ dry-run, per separate ...
4 years, 12 months ago (2015-12-28 15:04:44 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 15:24:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549383002/1
4 years, 12 months ago (2015-12-28 15:25:19 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 15:26:39 UTC) #17
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 15:27:29 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b42c6cfc665a81b903ffed709883121b3acee43
Cr-Commit-Position: refs/heads/master@{#33048}

Powered by Google App Engine
This is Rietveld 408576698