Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1549373004: Fix an unneeded std::move in //third_party/libaddressinput. (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an unneeded std::move in //third_party/libaddressinput. std::move is not needed when returning local variables. This wasn't caught in the initial commit because only Windows builds //third_party with -Wall. BUG=82385 TBR=thakis@chromium.org Committed: https://crrev.com/f0e2963a777189ff269b2bb48b1882f55301afae Cr-Commit-Position: refs/heads/master@{#367043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/libaddressinput/chromium/json.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcheng
Note: I'm separating this from the README changes (mainly because I'm not sure what to ...
4 years, 12 months ago (2015-12-29 02:11:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549373004/1
4 years, 12 months ago (2015-12-29 02:11:34 UTC) #3
Nico
lgtm, thanks!
4 years, 12 months ago (2015-12-29 02:15:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-29 03:03:01 UTC) #7
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 03:03:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0e2963a777189ff269b2bb48b1882f55301afae
Cr-Commit-Position: refs/heads/master@{#367043}

Powered by Google App Engine
This is Rietveld 408576698