Issue 154933004: Replace some asserts with Exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 154933004: Replace some asserts with Exceptions. (Closed)

Created:
6 years, 10 months ago by achuithb

Modified:
6 years, 10 months ago

Reviewers:
Tim Song

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Replace some asserts with Exceptions. These asserts may cause telemetry to silently exit - we'd prefer a stack trace. BUG=338622 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248843

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/154933004/1

6 years, 10 months ago (2014-02-05 03:53:33 UTC) #4

Message was sent while issue was closed.

Change committed as 248843