Persist server's crypto config data to disk cache for 0-RTT

net/quic/quic_crypto_client_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_CRYPTO_CLIENT_STREAM_H_
 #define NET_QUIC_QUIC_CRYPTO_CLIENT_STREAM_H_
 
 #include <string>
 
 #include "net/cert/cert_verify_result.h"
@@ skipping 30 matching lines @@
   virtual bool CryptoConnect();
 
   // num_sent_client_hellos returns the number of client hello messages that
   // have been sent. If the handshake has completed then this is one greater
   // than the number of round-trips needed for the handshake.
   int num_sent_client_hellos() const;
 
   // Gets the SSL connection information.
   virtual bool GetSSLInfo(SSLInfo* ssl_info);
 
+  void OnIOComplete(int result);
+
  private:
   // ProofVerifierCallbackImpl is passed as the callback method to VerifyProof.
   // The ProofVerifier calls this class with the result of proof verification
   // when verification is performed asynchronously.
   class ProofVerifierCallbackImpl : public ProofVerifierCallback {
    public:
     explicit ProofVerifierCallbackImpl(QuicCryptoClientStream* stream);
     virtual ~ProofVerifierCallbackImpl();
 
     // ProofVerifierCallback interface.
     virtual void Run(bool ok,
                      const string& error_details,
                      scoped_ptr<ProofVerifyDetails>* details) OVERRIDE;
 
     // Cancel causes any future callbacks to be ignored. It must be called on
     // the same thread as the callback will be made on.
     void Cancel();
 
    private:
     QuicCryptoClientStream* stream_;
   };
 
   friend class test::CryptoTestUtils;
   friend class ProofVerifierCallbackImpl;
 
   enum State {
     STATE_IDLE,
+    STATE_LOAD_QUIC_SERVER_INFO,
     STATE_SEND_CHLO,
     STATE_RECV_REJ,
     STATE_VERIFY_PROOF,
     STATE_VERIFY_PROOF_COMPLETE,
     STATE_RECV_SHLO,
   };
 
   // DoHandshakeLoop performs a step of the handshake state machine. Note that
   // |in| may be NULL if the call did not result from a received message
   void DoHandshakeLoop(const CryptoHandshakeMessage* in);
 
+  // Calls QuicServerInfo's WaitForDataReady to load the server information from
+  // the disk cache.
+  int DoLoadQuicServerInfo(QuicCryptoClientConfig::CachedState* cached);

[wtc, 2014/02/07 00:54:11]

Right now STATE_LOAD_QUIC_SERVER_INFO is the only state that has a DoXXX
function.

Please add a TODO comment to convert the other states of the state machine into
DoXXX functions. Alternatively, just inline this function into DoHandshakeLoop.

[ramant (doing other things), 2014/02/07 20:30:51]

Added a TODO.

Done.

+
   State next_state_;
   // num_client_hellos_ contains the number of client hello messages that this
   // connection has sent.
   int num_client_hellos_;
 
   QuicCryptoClientConfig* const crypto_config_;
 
   // Client's connection nonce (4-byte timestamp + 28 random bytes)
   std::string nonce_;
   // Server's hostname
@@ skipping 15 matching lines @@
 
   // The result of certificate verification.
   scoped_ptr<CertVerifyResult> cert_verify_result_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicCryptoClientStream);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_CRYPTO_CLIENT_STREAM_H_