Persist server's crypto config data to disk cache for 0-RTT

net/quic/crypto/quic_server_info.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CRYPTO_QUIC_SERVER_INFO_H_
 #define NET_QUIC_CRYPTO_QUIC_SERVER_INFO_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 39 matching lines @@
   // only be called once WaitForDataReady has returned OK or called its
   // callback.
   virtual void Persist() = 0;
 
   struct State {
     State();
     ~State();
 
     void Clear();
 
-    // TODO(rtenneti): figure out what are the data members.
-    std::vector<std::string> data;
+    std::string server_config_;         // A serialized handshake message.

[wtc, 2014/02/07 00:54:11]

1. Please add a comment to document this class matches
QuicClientCryptoConfig::CachedState.

2. Should we also persist server_config_id_?

[ramant (doing other things), 2014/02/07 20:30:51]

server_config_id_ is not used. Added a comment to delete that member.

Done.

+    std::string source_address_token_;  // An opaque proof of IP ownership.
+    std::string server_config_sig_;     // A signature of |server_config_|.
+    std::vector<std::string> certs_;    // A list of certificates in leaf-first
+                                        // order.

[wtc, 2014/02/07 00:54:11]

Nit: it may be better to swap server_config_sig_ and certs_ so that they are
declared in the same order as in QuicClientCryptoConfig::CachedState.

For convenience we can still serialize server_config_sig_ before certs_.

[ramant (doing other things), 2014/02/07 20:30:51]

Done.

 
    private:
     DISALLOW_COPY_AND_ASSIGN(State);
   };
 
   // Once the data is ready, it can be read using the following members. These
   // members can then be updated before calling |Persist|.
   const State& state() const;
   State* mutable_state();
 
+  // Returns true if we have loaded the data from disk cache (disk cache had
+  // the data and that data was successfully parsed).
+  bool data_loaded() const { return data_loaded_; }
+
  protected:
-  // Parse parses an opaque blob of data and fills out the public member fields
-  // of this object. It returns true iff the parse was successful. The public
-  // member fields will be set to something sane in any case.
+  // Parse parses pickled data and fills out the public member fields of this
+  // object. It returns true iff the parse was successful. The public member
+  // fields will be set to something sane in any case.
   bool Parse(const std::string& data);
   std::string Serialize() const;
   State state_;
 
  private:
   // ParseInner is a helper function for Parse.
   bool ParseInner(const std::string& data);
 
   // This is the QUIC server hostname for which we restore the crypto_config.
   const std::string hostname_;
+  bool data_loaded_;
   base::WeakPtrFactory<QuicServerInfo> weak_factory_;

[wtc, 2014/02/07 00:54:11]

This member is not being used.

[ramant (doing other things), 2014/02/07 20:30:51]

Done.

 };
 
 class QuicServerInfoFactory {
  public:
   virtual ~QuicServerInfoFactory();
 
   // GetForHost returns a fresh, allocated QuicServerInfo for the given
   // hostname or NULL on failure.
   virtual QuicServerInfo* GetForHost(const std::string& hostname) = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_CRYPTO_QUIC_SERVER_INFO_H_