Persist server's crypto config data to disk cache for 0-RTT

net/quic/crypto/quic_crypto_client_config.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CRYPTO_QUIC_CRYPTO_CLIENT_CONFIG_H_
 #define NET_QUIC_CRYPTO_QUIC_CRYPTO_CLIENT_CONFIG_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 49 matching lines @@
     void InvalidateServerConfig();
 
     // SetProof stores a certificate chain and signature.
     void SetProof(const std::vector<std::string>& certs,
                   base::StringPiece signature);
 
     // Clears the certificate chain and signature and invalidates the proof.
     void ClearProof();
 
     // SetProofValid records that the certificate chain and signature have been
-    // validated and that it's safe to assume that the server is legitimate.
+    // validated and that it's safe to assume that the server is legitimate. It
+    // calls SaveQuicServerInfo() to persist the server config information to

[wtc, 2014/02/13 23:48:43]

Nit: it is not necessary to mention it calls SaveQuicServerInfo. Just say "It
persists the server config information to disk cache."

[ramant (doing other things), 2014/02/15 00:36:12]

Done.

+    // disk cache.
     // (Note: this does not check the chain or signature.)
     void SetProofValid();
 
     // If the server config or the proof has changed then it needs to be
     // revalidated. Helper function to keep server_config_valid_ and
     // generation_counter_ in sync.
     void SetProofInvalid();
 
     const std::string& server_config() const;
     const std::string& source_address_token() const;
     const std::vector<std::string>& certs() const;
     const std::string& signature() const;
     bool proof_valid() const;
     uint64 generation_counter() const;
     const ProofVerifyDetails* proof_verify_details() const;
+    QuicServerInfo* quic_server_info() const;
 
     void set_source_address_token(base::StringPiece token);
 
     // SetProofVerifyDetails takes ownership of |details|.
     void SetProofVerifyDetails(ProofVerifyDetails* details);
 
     // Copy the |server_config_|, |source_address_token_|, |certs_| and
     // |server_config_sig_| from the |other|.  The remaining fields,
     // |generation_counter_|, |proof_verify_details_|, and |scfg_| remain
     // unchanged.
     void InitializeFrom(const CachedState& other);
 
+    // Fill out the |server_config_|, |source_address_token_|, |certs_| and
+    // |server_config_sig_| fields from |quic_server_info_|. |quic_server_info_|
+    // reads this information from the disk cache.
+    void LoadQuicServerInfo();
+
+    // Save the server config information so that we can perform 0-RTT handshake
+    // with a server.
+    void SaveQuicServerInfo();
+
    private:
+    // TODO(rtenneti): |server_config_id_| is not being used, delete it.

[wtc, 2014/02/13 23:48:43]

You can delete this TODO comment now because I just deleted |server_config_id_|.

[ramant (doing other things), 2014/02/15 00:36:12]

Done.

     std::string server_config_id_;      // An opaque id from the server.
     std::string server_config_;         // A serialized handshake message.
     std::string source_address_token_;  // An opaque proof of IP ownership.
     std::vector<std::string> certs_;    // A list of certificates in leaf-first
                                         // order.
     std::string server_config_sig_;     // A signature of |server_config_|.
     bool server_config_valid_;          // True if |server_config_| is correctly
                                         // signed and |certs_| has been
                                         // validated.
+    bool need_to_persist_;              // Persist to disk if True.
     // Generation counter associated with the |server_config_|, |certs_| and
     // |server_config_sig_| combination. It is incremented whenever we set
     // server_config_valid_ to false.
     uint64 generation_counter_;
 
     scoped_ptr<ProofVerifyDetails> proof_verify_details_;
 
     // scfg contains the cached, parsed value of |server_config|.
     mutable scoped_ptr<CryptoHandshakeMessage> scfg_;
 
@@ skipping 112 matching lines @@
 
   scoped_ptr<ProofVerifier> proof_verifier_;
   scoped_ptr<ChannelIDSigner> channel_id_signer_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicCryptoClientConfig);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_CRYPTO_QUIC_CRYPTO_CLIENT_CONFIG_H_