Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1549313002: Add a missing switch-case break in Accessibility (Closed)

Created:
4 years, 12 months ago by tzik
Modified:
4 years, 12 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing switch-case break in Accessibility BUG= Committed: https://crrev.com/d3588a1d393d16e8e9ef7c5daa3081a08b9c8b9d Cr-Commit-Position: refs/heads/master@{#366984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M ui/accessibility/ax_node_data.cc View 1 chunk +16 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549313002/1
4 years, 12 months ago (2015-12-28 01:11:52 UTC) #2
tzik
PTAL. It looks unintentional to fall-through from AX_ATTR_TEXT_DIRECTION to AX_ATTR_TEXT_STYLE in the switch-case. Can I ...
4 years, 12 months ago (2015-12-28 01:16:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 02:36:52 UTC) #6
dmazzoni
lgtm
4 years, 12 months ago (2015-12-28 16:50:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549313002/1
4 years, 12 months ago (2015-12-28 16:50:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 16:53:58 UTC) #10
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 16:54:52 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d3588a1d393d16e8e9ef7c5daa3081a08b9c8b9d
Cr-Commit-Position: refs/heads/master@{#366984}

Powered by Google App Engine
This is Rietveld 408576698