Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: net/quic/quic_chromium_client_session.cc

Issue 1549303002: Add a missing switch-case break in Quic code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_chromium_client_session.h" 5 #include "net/quic/quic_chromium_client_session.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 uint16_t cipher_suite; 475 uint16_t cipher_suite;
476 int security_bits; 476 int security_bits;
477 switch (aead) { 477 switch (aead) {
478 case kAESG: 478 case kAESG:
479 cipher_suite = 0xc02f; // TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 479 cipher_suite = 0xc02f; // TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
480 security_bits = 128; 480 security_bits = 128;
481 break; 481 break;
482 case kCC12: 482 case kCC12:
483 cipher_suite = 0xcc13; // TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 483 cipher_suite = 0xcc13; // TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256
484 security_bits = 256; 484 security_bits = 256;
485 break;
485 case kCC20: 486 case kCC20:
486 cipher_suite = 0xcc13; // TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 487 cipher_suite = 0xcc13; // TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256
487 security_bits = 256; 488 security_bits = 256;
488 break; 489 break;
489 default: 490 default:
490 NOTREACHED(); 491 NOTREACHED();
491 return false; 492 return false;
492 } 493 }
493 int ssl_connection_status = 0; 494 int ssl_connection_status = 0;
494 ssl_connection_status |= cipher_suite; 495 ssl_connection_status |= cipher_suite;
(...skipping 487 matching lines...) Expand 10 before | Expand all | Expand 10 after
982 return; 983 return;
983 984
984 // TODO(rch): re-enable this code once beta is cut. 985 // TODO(rch): re-enable this code once beta is cut.
985 // if (stream_factory_) 986 // if (stream_factory_)
986 // stream_factory_->OnSessionConnectTimeout(this); 987 // stream_factory_->OnSessionConnectTimeout(this);
987 // CloseAllStreams(ERR_QUIC_HANDSHAKE_FAILED); 988 // CloseAllStreams(ERR_QUIC_HANDSHAKE_FAILED);
988 // DCHECK_EQ(0u, GetNumOpenOutgoingStreams()); 989 // DCHECK_EQ(0u, GetNumOpenOutgoingStreams());
989 } 990 }
990 991
991 } // namespace net 992 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698