Take care fall-through case of switch in skia

Take care fall-through case of switch in skia

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1549273002

Committed: https://skia.googlesource.com/skia/+/bc7d235c8b0ddbe7080c6e9eba5b617fddc16135

[tzik, 2015-12-27 22:57:47]

Description was changed from

==========
Take care fall-through case of switch in skia
==========

to

==========
Take care fall-through case of switch in skia
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[tzik, 2015-12-27 22:59:40]

Description was changed from

==========
Take care fall-through case of switch in skia
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Take care fall-through case of switch in skia

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[tzik, 2015-12-27 22:59:40]

tzik@chromium.org changed reviewers:
+ reed@google.com

[tzik, 2015-12-27 22:59:50]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-27 22:59:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549273002/1

[commit-bot: I haz the power, 2015-12-27 22:59:58]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-12-28 04:59 UTC

[tzik, 2015-12-27 23:23:25]

PTAL.
Clang warns two switch-case on -Wimplicit-fallthrough warning option.
One seems a false-positive, and the other seems a minor bug.

[commit-bot: I haz the power, 2015-12-28 04:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-28 04:59:11]

Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

[reed1, 2015-12-28 18:29:35]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[reed1, 2015-12-28 18:29:35]

first change seems like it must be correct. not sure the 2nd one has to be.
Adding folks who may know.

[bsalomon, 2016-01-04 14:41:00]

lgtm

[tzik, 2016-01-05 08:21:15]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-01-05 08:21:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549273002/1

[commit-bot: I haz the power, 2016-01-05 08:35:53]

Description was changed from

==========
Take care fall-through case of switch in skia

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Take care fall-through case of switch in skia

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/bc7d235c8b0ddbe7080c6e9eba5b617fddc16135
==========

[commit-bot: I haz the power, 2016-01-05 08:35:53]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bc7d235c8b0ddbe7080c6e9eba5b617fddc16135