Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager.cc
diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc
index e70a3153d80b1bc38acead280b86dd3da52e9135..606183d0c3ce2d7c9d2978ee0039f7328c068d12 100644
--- a/chrome/browser/extensions/menu_manager.cc
+++ b/chrome/browser/extensions/menu_manager.cc
@@ -6,6 +6,7 @@
#include <algorithm>
#include <tuple>
+#include <utility>
#include "base/json/json_writer.h"
#include "base/logging.h"
@@ -214,7 +215,7 @@ scoped_ptr<base::DictionaryValue> MenuItem::ToValue() const {
value->Set(kDocumentURLPatternsKey,
document_url_patterns_.ToValue().release());
value->Set(kTargetURLPatternsKey, target_url_patterns_.ToValue().release());
- return value.Pass();
+ return value;
}
// static
@@ -718,7 +719,8 @@ void MenuManager::ExecuteCommand(content::BrowserContext* context,
scoped_ptr<base::ListValue>(args->DeepCopy())));
event->restrict_to_browser_context = context;
event->user_gesture = EventRouter::USER_GESTURE_ENABLED;
- event_router->DispatchEventToExtension(item->extension_id(), event.Pass());
+ event_router->DispatchEventToExtension(item->extension_id(),
+ std::move(event));
}
{
// Dispatch to .contextMenus.onClicked handler.
@@ -727,12 +729,13 @@ void MenuManager::ExecuteCommand(content::BrowserContext* context,
: events::CONTEXT_MENUS_ON_CLICKED,
webview_guest ? api::chrome_web_view_internal::OnClicked::kEventName
: api::context_menus::OnClicked::kEventName,
- args.Pass()));
+ std::move(args)));
event->restrict_to_browser_context = context;
event->user_gesture = EventRouter::USER_GESTURE_ENABLED;
if (webview_guest)
event->filter_info.SetInstanceID(webview_guest->view_instance_id());
- event_router->DispatchEventToExtension(item->extension_id(), event.Pass());
+ event_router->DispatchEventToExtension(item->extension_id(),
+ std::move(event));
}
}
« no previous file with comments | « chrome/browser/extensions/isolated_app_browsertest.cc ('k') | chrome/browser/extensions/permissions_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698