chrome/browser/extensions/extension_management_test_util.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management_test_util.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_management_internal.cc ('k') | chrome/browser/extensions/extension_messages_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_management_test_util.cc

diff --git a/chrome/browser/extensions/extension_management_test_util.cc b/chrome/browser/extensions/extension_management_test_util.cc

index 1b288ea2cc3dd5ba7f5976199e5ba790d0df611b..b33464f6b7c080a7982100a22cb0526e198dd05f 100644

--- a/chrome/browser/extensions/extension_management_test_util.cc

+++ b/chrome/browser/extensions/extension_management_test_util.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/extensions/extension_management_test_util.h"

#include <string>

+#include <utility>

#include "components/crx_file/id_util.h"

#include "components/policy/core/common/configuration_policy_provider.h"

@@ -216,7 +217,7 @@ void ExtensionManagementPrefUpdaterBase::SetPref(base::DictionaryValue* pref) {

scoped_ptr<base::DictionaryValue>

ExtensionManagementPrefUpdaterBase::TakePref() {

- return pref_.Pass();

+ return std::move(pref_);

}

void ExtensionManagementPrefUpdaterBase::ClearList(const std::string& path) {

@@ -265,7 +266,7 @@ ExtensionManagementPolicyUpdater::~ExtensionManagementPolicyUpdater() {

.Set(policy::key::kExtensionSettings, policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

TakePref().release(), nullptr);

- provider_->UpdatePolicy(policies_.Pass());

+ provider_->UpdatePolicy(std::move(policies_));

}

} // namespace extensions