chrome/browser/extensions/extension_install_prompt_unittest.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_prompt_unittest.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_install_prompt.cc ('k') | chrome/browser/extensions/extension_keybinding_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_prompt_unittest.cc

diff --git a/chrome/browser/extensions/extension_install_prompt_unittest.cc b/chrome/browser/extensions/extension_install_prompt_unittest.cc

index 7b1c31f0583d08ccb0f17bc6589b4f11f6206923..65eebf62d755e11fb115cade3b3ab1c49a497748 100644

--- a/chrome/browser/extensions/extension_install_prompt_unittest.cc

+++ b/chrome/browser/extensions/extension_install_prompt_unittest.cc

@@ -117,7 +117,7 @@ TEST_F(ExtensionInstallPromptUnitTest, PromptShowsPermissionWarnings) {

extension.get(), nullptr,

make_scoped_ptr(new ExtensionInstallPrompt::Prompt(

ExtensionInstallPrompt::PERMISSIONS_PROMPT)),

- permission_set.Pass(),

+ std::move(permission_set),

base::Bind(&VerifyPromptPermissionsCallback, run_loop.QuitClosure(),

1u, // |regular_permissions_count|.

0u)); // |withheld_permissions_count|.

@@ -184,7 +184,7 @@ TEST_F(ExtensionInstallPromptUnitTest,

sub_prompt->set_delegated_username("Username");

prompt.ShowDialog(

nullptr, // no delegate

- extension.get(), nullptr, sub_prompt.Pass(),

+ extension.get(), nullptr, std::move(sub_prompt),

base::Bind(&VerifyPromptPermissionsCallback, run_loop.QuitClosure(),

2u, // |regular_permissions_count|.

0u)); // |withheld_permissions_count|.