chrome/browser/extensions/extension_disabled_ui.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_disabled_ui.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model_unittest.cc ('k') | chrome/browser/extensions/extension_function_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_disabled_ui.cc

diff --git a/chrome/browser/extensions/extension_disabled_ui.cc b/chrome/browser/extensions/extension_disabled_ui.cc

index 54a133217770fee8bc6c16f58b4b03a5d5c39b3f..0e096b5e6bff9c2de7392605fd8043c72faa8bf5 100644

--- a/chrome/browser/extensions/extension_disabled_ui.cc

+++ b/chrome/browser/extensions/extension_disabled_ui.cc

@@ -6,6 +6,7 @@

#include <bitset>

#include <string>

+#include <utility>

#include "base/bind.h"

#include "base/lazy_instance.h"

@@ -119,7 +120,7 @@ ExtensionDisabledDialogDelegate::ExtensionDisabledDialogDelegate(

ExtensionService* service,

scoped_ptr<ExtensionInstallPrompt> install_ui,

const Extension* extension)

- : install_ui_(install_ui.Pass()),

+ : install_ui_(std::move(install_ui)),

service_(service),

extension_(extension) {

AddRef(); // Balanced in Proceed or Abort.

@@ -511,7 +512,8 @@ void ShowExtensionDisabledDialog(ExtensionService* service,

scoped_ptr<ExtensionInstallPrompt> install_ui(

new ExtensionInstallPrompt(web_contents));

// This object manages its own lifetime.

- new ExtensionDisabledDialogDelegate(service, install_ui.Pass(), extension);

+ new ExtensionDisabledDialogDelegate(service, std::move(install_ui),

+ extension);

}

} // namespace extensions