chrome/browser/extensions/crx_installer.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_extensions_browser_client.cc ('k') | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 92bf9c522d3d90c43041146614e87afde2351a4c..3663a17a5913bd1682e67776eb4c0b7f63dfd548 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -6,6 +6,7 @@

#include <map>

#include <set>

+#include <utility>

#include "base/bind.h"

#include "base/files/file_util.h"

@@ -96,7 +97,7 @@ scoped_refptr<CrxInstaller> CrxInstaller::CreateSilent(

scoped_refptr<CrxInstaller> CrxInstaller::Create(

ExtensionService* frontend,

scoped_ptr<ExtensionInstallPrompt> client) {

- return new CrxInstaller(frontend->AsWeakPtr(), client.Pass(), NULL);

+ return new CrxInstaller(frontend->AsWeakPtr(), std::move(client), NULL);

}

// static

@@ -104,7 +105,7 @@ scoped_refptr<CrxInstaller> CrxInstaller::Create(

ExtensionService* service,

scoped_ptr<ExtensionInstallPrompt> client,

const WebstoreInstaller::Approval* approval) {

- return new CrxInstaller(service->AsWeakPtr(), client.Pass(), approval);

+ return new CrxInstaller(service->AsWeakPtr(), std::move(client), approval);

}

CrxInstaller::CrxInstaller(base::WeakPtr<ExtensionService> service_weak,