chrome/browser/extensions/chrome_extension_function.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_function.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/bundle_installer.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extension_function.cc

diff --git a/chrome/browser/extensions/chrome_extension_function.cc b/chrome/browser/extensions/chrome_extension_function.cc

index fe662dd4a97ff96e56f3041e2f9ac2717fe3e3e3..9519a5f588ac50a809416f5c25cd10ab5c568efb 100644

--- a/chrome/browser/extensions/chrome_extension_function.cc

+++ b/chrome/browser/extensions/chrome_extension_function.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/chrome_extension_function.h"

+#include <utility>

#include "chrome/browser/extensions/chrome_extension_function_details.h"

#include "chrome/browser/extensions/window_controller.h"

#include "chrome/browser/extensions/window_controller_list.h"

@@ -116,7 +118,8 @@ ChromeSyncExtensionFunction::ChromeSyncExtensionFunction() {

ChromeSyncExtensionFunction::~ChromeSyncExtensionFunction() {}

ExtensionFunction::ResponseAction ChromeSyncExtensionFunction::Run() {

- return RespondNow(RunSync() ? ArgumentList(results_.Pass()) : Error(error_));

+ return RespondNow(RunSync() ? ArgumentList(std::move(results_))

+ : Error(error_));

}

// static

« no previous file with comments | « chrome/browser/extensions/bundle_installer.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »