chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc ('k') | chrome/browser/extensions/api/system_private/system_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

diff --git a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc b/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

index 9dfe3feef6db141dcdf0b20d6692a3816fd0941f..7ebe877baf23931c90901b15b2e47d30529e60ce 100644

--- a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

+++ b/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/system_indicator/system_indicator_manager.h"

+#include <utility>

#include "base/memory/linked_ptr.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/extensions/extension_action.h"

@@ -84,9 +86,8 @@ void ExtensionIndicatorIcon::OnStatusIconClicked() {

EventRouter* event_router = EventRouter::Get(profile_);

scoped_ptr<Event> event(new Event(events::SYSTEM_INDICATOR_ON_CLICKED,

system_indicator::OnClicked::kEventName,

- params.Pass(), profile_));

- event_router->DispatchEventToExtension(

- extension_->id(), event.Pass());

+ std::move(params), profile_));

+ event_router->DispatchEventToExtension(extension_->id(), std::move(event));

}

void ExtensionIndicatorIcon::OnIconUpdated() {