chrome/browser/extensions/api/storage/setting_sync_data.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/setting_sync_data.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/policy_value_store.cc ('k') | chrome/browser/extensions/api/storage/settings_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/setting_sync_data.cc

diff --git a/chrome/browser/extensions/api/storage/setting_sync_data.cc b/chrome/browser/extensions/api/storage/setting_sync_data.cc

index cf7cbf6585bf7f2d4a99b25a697467e856e4474c..214729422c0743b4f74017c3852990a099d6d07f 100644

--- a/chrome/browser/extensions/api/storage/setting_sync_data.cc

+++ b/chrome/browser/extensions/api/storage/setting_sync_data.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/storage/setting_sync_data.h"

+#include <utility>

#include "base/json/json_reader.h"

#include "base/json/json_writer.h"

#include "sync/api/sync_data.h"

@@ -30,14 +32,13 @@ SettingSyncData::SettingSyncData(syncer::SyncChange::SyncChangeType change_type,

: change_type_(change_type),

extension_id_(extension_id),

key_(key),

- value_(value.Pass()) {

+ value_(std::move(value)) {}

SettingSyncData::~SettingSyncData() {}

scoped_ptr<base::Value> SettingSyncData::PassValue() {

DCHECK(value_) << "value has already been Pass()ed";

- return value_.Pass();

+ return std::move(value_);

}

void SettingSyncData::ExtractSyncData(const syncer::SyncData& sync_data) {