chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc

index 2838196cb0214f2198e989aec1ddc0fc1b66dcae..9de72ed3e625e5e338436a8f21a7fadf46522a32 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc

@@ -74,7 +74,7 @@ ScopedVector<DeviceInfo> GetAllSignedInDevices(

extension_prefs->UpdateExtensionPref(extension_id,

kPrefStringForIdMapping,

editable_mapping_dictionary.release());

- return devices.Pass();

+ return devices;

}

ScopedVector<DeviceInfo> GetAllSignedInDevices(

@@ -87,7 +87,7 @@ ScopedVector<DeviceInfo> GetAllSignedInDevices(

DCHECK(device_tracker);

if (!device_tracker->IsSyncing()) {

// Devices are not sync'ing.

- return ScopedVector<DeviceInfo>().Pass();

+ return ScopedVector<DeviceInfo>();

}

ExtensionPrefs* extension_prefs = ExtensionPrefs::Get(profile);

@@ -108,7 +108,7 @@ scoped_ptr<DeviceInfo> GetLocalDeviceInfo(const std::string& extension_id,

scoped_ptr<DeviceInfo> device = GetDeviceInfoForClientId(guid,

extension_id,

profile);

- return device.Pass();

+ return device;

}

bool SignedInDevicesGetFunction::RunSync() {