chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_process_launcher.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc

diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc b/chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc

index 22976865c1f13535f2f71eb8f67fcd70c8f98974..3b62003d6d65c853ff5e8ee70fee0bf930891698 100644

--- a/chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc

+++ b/chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/messaging/native_process_launcher.h"

+#include <utility>

#include "base/command_line.h"

#include "base/files/file_util.h"

#include "base/files/scoped_file.h"

@@ -91,7 +93,7 @@ bool NativeProcessLauncher::LaunchNativeProcess(

write_pipe_read_fd.reset();

read_pipe_write_fd.reset();

- *process = local_process.Pass();

+ *process = std::move(local_process);

*read_file = base::File(read_pipe_read_fd.release());

*write_file = base::File(write_pipe_write_fd.release());