chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc ('k') | chrome/browser/extensions/api/messaging/native_process_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc b/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

index 170ca99ec2a03ac39f4338e5bfc003a0271a3c3c..ad0ab658e0b78f7c3e2ed0710d3ccfcd4d72713a 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/messaging/native_messaging_policy_handler.h"

+#include <utility>

#include "base/logging.h"

#include "base/prefs/pref_value_map.h"

#include "chrome/browser/extensions/api/messaging/native_messaging_host_manifest.h"

@@ -37,7 +39,7 @@ void NativeMessagingHostListPolicyHandler::ApplyPolicySettings(

scoped_ptr<base::ListValue> list;

policy::PolicyErrorMap errors;

if (CheckAndGetList(policies, &errors, &list) && list)

- prefs->SetValue(pref_path(), list.Pass());

+ prefs->SetValue(pref_path(), std::move(list));

}

const char* NativeMessagingHostListPolicyHandler::pref_path() const {

@@ -84,7 +86,7 @@ bool NativeMessagingHostListPolicyHandler::CheckAndGetList(

}

if (names)

- *names = filtered_list.Pass();

+ *names = std::move(filtered_list);

return true;

}